-
Notifications
You must be signed in to change notification settings - Fork 308
Revamp the "Build" section. #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Taking a quick look over this and there are a few issues I think we should solve before going this route.
|
@cwaring No worries, I'll fix them now.
@cwaring if this is too hard to do right now then let's just scrap it. I found going through the tutorials in there current state confusing and convoluted, and I had to keep referring back to previous pages to understand what as going on. That problem is because of the general structure of these tutorials needs re-writing, but because we're short on time moving things into a single page was a quick fix. But again, if it's too hard to get the right analytics sorted, I'll just scrap it and we'll re-organize the tutorials down the line.
@cwaring Yeahp, I'm aware. That's why this PR is still a draft. Waiting for that merge to go in so I can cherry pick the changes from here. |
@johnnymatthews thanks! I would rather us work towards the best reading experience and if you think a single page for these types of tutorials works then let's to that and I can wire in any extras to fit later, for now I just wanted to throw it into the ring for consideration :) |
The In general this is a MASSIVE PR that is hard to follow along with. Any chance this could be split into smaller changes — the refactor first, and then significant batches of content edits in their own PRs? |
@cwaring I'm confused. Do you want me to revert the
@mishmosh yeah probably. Where do you reckon it should go? It could go into the new Install Filecoin section (pending PR review).
@mishmosh yeah sorry about that. I was told we needed to move fast and get stuff out the door before Space Race. I didn't expect this PR to face much review/discussion. If @cwaring would like to revert back to the |
Keep them as single pages if that improves the reading exp, I just wanted to note potential issues so we can track and fix in future updates. If we use this same pattern for other tutorials then that will be great. |
Closing this PR because it's become far too difficult to manage. I've created another, easier to follow, PR that contains a handful of the issues addressed here. #332. I'm not deleting the branch just in case we need to come back here at some point soon. |
The Build section is a bit of a mess, and needs reorganizing. This PR will likely need tweaking to fit with @cwaring's layout and sidebar changes.
Closes #248
Tasks
build/networks
page.build/getting-started
explain how to set up a node once the reader has finished installing Lotus (there likely isn't much they have to do).build/getting-started
page to test the readers set up.5a xyz
, etc)