Skip to content

avoid forced/implicit conversion #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

avoid forced/implicit conversion #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3f7e94
test
george2209 Nov 11, 2019
99aaea4
adding some changes to avoid possible memory leak
george2209 Nov 24, 2019
a627b5a
roll back a comment
george2209 Nov 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/WebsocketHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,15 @@ void WebsocketHandler::send(uint8_t* data, uint16_t length, uint8_t sendType) {
frame.len = 126;
_con->writeBuffer((uint8_t *)&frame, sizeof(frame));
uint16_t net_len = htons(length);
_con->writeBuffer((uint8_t *) net_len, sizeof(uint16_t)); // Convert to network byte order from host byte order
//replaced by George2209 on 2019-11-11 (avoid forced/implicit conversion):
//_con->writeBuffer((uint8_t *) net_len, sizeof(uint16_t)); // Convert to network byte order from host byte order
//start of replacement of the upper line:
{
uint8_t tmp_buffer[sizeof(uint16_t)];
memcpy(tmp_buffer,&net_len,sizeof(uint16_t));
_con->writeBuffer(tmp_buffer, sizeof(uint16_t)); // Convert to network byte order from host byte order
}
//end of replacement of George2209
}
_con->writeBuffer(data, length);
HTTPS_LOGD("<< Websocket.send()");
Expand Down