Fixes a bug that prevented using complex dictionaries within compositions #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikopavlica Nice work, will test the PR in some API's and let you know how it goes |
|
@ferdikoomen any news about merging this one or maybe any help needed? Really waiting for it to be merged, thx! |
ferdikoomen
approved these changes
Feb 25, 2022
|
@vyobukhov @nikopavlica merged, will release a new version soon (0.20.0), fixing some other bugs as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964.
In case of "simple" dictionary (
Record<string, number>orRecord<string,array<number>>, model.type was set tonumberinparser/getModel.tsfunction. But in case of composite,typewas not explicitly set and defaulted toany.I didn't want to change this type in the
getModelfunction, as it might have some other implications, so I just added another check in when to ignore a model within composition.Added 3 more test objects to the suite, so it covers all three cases.