Skip to content

[WIP] Migrate Webpack 4 support branch #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 29, 2018
Merged

[WIP] Migrate Webpack 4 support branch #69

merged 13 commits into from
May 29, 2018

Conversation

ScriptedAlchemy
Copy link
Collaborator

Think its time to work off the main repo and not my fork.

Yay or nay?

Also will commitizen screw anything up by merging to a non master branch? I know little about it

Webpack 4 support for extract-css-chunks universal-component react-universal. Complete with full
chunking, code splitting, real and true hot module reloading. Compatible with faceyspacey universal
code splitting and server-side rendering.

BREAKING CHANGE: EVERYTHING! This its a complete rewrite. Top to bottom!! This is a major change to
the API and Loader. It will intergrate with universal without a issue and  IT DOES NOT RELY ON
UNIVERSAL COMPONENTS.

fix #60, re #36 #47 #51
…otfiles

Staging back in stuff to be deleted in hopes of reducing the size of the inital PR. Housekeeping on dotfiles and such

Adding the ability to prepack install from git directly
Fixed issues with namespacing that was causing compile issue in near production systems
Removing the old tests and implementing the new ones, we are missing some coverage
Linting the whole app so its less of a pain to use commitizen
Using a version of normalize-url which is too new and could be causing issues
New docs on implementation, API, Reasons for updateing. Currently a WIP
removing old JS files from the previous implementation, added yarn, cleaned up package deps a little
Notes on how to install a the package via a git branch
Testing collapsable summery block in order to hide the old documentation during beta/i can finish
updating it
@ScriptedAlchemy ScriptedAlchemy self-assigned this May 28, 2018
@ScriptedAlchemy
Copy link
Collaborator Author

NOT FOR MASTER RELEASE: Just consolidating.

Fixing bug where loader broke due to iteration over an object key that was a string and not an array
@ScriptedAlchemy ScriptedAlchemy merged commit 2e83dd0 into faceyspacey:webpack-4 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant