-
Notifications
You must be signed in to change notification settings - Fork 85
[WIP] Migrate Webpack 4 support branch #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ScriptedAlchemy
merged 13 commits into
faceyspacey:webpack-4
from
ScriptedAlchemy:webpack-4
May 29, 2018
Merged
[WIP] Migrate Webpack 4 support branch #69
ScriptedAlchemy
merged 13 commits into
faceyspacey:webpack-4
from
ScriptedAlchemy:webpack-4
May 29, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack 4 support for extract-css-chunks universal-component react-universal. Complete with full chunking, code splitting, real and true hot module reloading. Compatible with faceyspacey universal code splitting and server-side rendering. BREAKING CHANGE: EVERYTHING! This its a complete rewrite. Top to bottom!! This is a major change to the API and Loader. It will intergrate with universal without a issue and IT DOES NOT RELY ON UNIVERSAL COMPONENTS. fix #60, re #36 #47 #51
…otfiles Staging back in stuff to be deleted in hopes of reducing the size of the inital PR. Housekeeping on dotfiles and such Adding the ability to prepack install from git directly
Fixed issues with namespacing that was causing compile issue in near production systems
Removing the old tests and implementing the new ones, we are missing some coverage
Linting the whole app so its less of a pain to use commitizen
Using a version of normalize-url which is too new and could be causing issues
New docs on implementation, API, Reasons for updateing. Currently a WIP
removing old JS files from the previous implementation, added yarn, cleaned up package deps a little
Notes on how to install a the package via a git branch
Testing collapsable summery block in order to hide the old documentation during beta/i can finish updating it
NOT FOR MASTER RELEASE: Just consolidating. |
Fixing bug where loader broke due to iteration over an object key that was a string and not an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think its time to work off the main repo and not my fork.
Yay or nay?
Also will commitizen screw anything up by merging to a non master branch? I know little about it