Skip to content

Moved querying of environment variable #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

swernerx
Copy link
Contributor

This fixes issues when environment variable is not configured before importing the module... which can be true for I figure a lot of Webpack configuration generators/factories like edge-builder. It imports dependencies via ESM import and executes the main function afterwards to parse command line arguments, etc.

This fixes issues when environment variable is not configured before importing the module... which can be true for I figure a lot of Webpack configuration generators/factories like [edge-builder](https://github.com/sebastian-software/edge-builder). It imports dependencies via ESM import and executes the `main` function afterwards to parse command line arguments, etc.
@swernerx
Copy link
Contributor Author

This fixes HMR issues with CSS in edge-builder.

@swernerx
Copy link
Contributor Author

Not yet, actually.

@swernerx
Copy link
Contributor Author

Now it's actually working correctly (not just saying it does something) 👍

@faceyspacey faceyspacey merged commit f93375d into faceyspacey:master Jul 27, 2017
@faceyspacey
Copy link
Owner

excellent! ...thought we were gonna need a configuration option. I'm glad the checks work at runtime.

@faceyspacey
Copy link
Owner

one quick thing i forgot before i clicked merge: u gotta do npm run cm to make your commits so that the commits are properly formatted to trigger npm releases, changelogs, and publishing.

Do you mind making another small PR. it should have a commit message like this:

`fix($bump): force auto-publish of DEV environment variable fix'

Then, do anything in the code that would give u something to commit. Add a blank line at the end of the file. Rewrite something in the readme. Anything.

@swernerx
Copy link
Contributor Author

It's merged already... mhh.

@faceyspacey
Copy link
Owner

faceyspacey commented Jul 27, 2017

i was saying make another PR. if u havent started, dont worry about it. i'll handle it as soon as i can. I probably have a few things to rewrite in the docs here for the React Universal Component 2.0 release anyway.

@swernerx
Copy link
Contributor Author

Feel free to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants