Skip to content

CSS HMR Issues #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2018
Merged

CSS HMR Issues #114

merged 9 commits into from
Oct 23, 2018

Conversation

ScriptedAlchemy
Copy link
Collaborator

complex builds using various webpack configs, or using merge like structures -- often lead to various loader outputs, this adds more searching for the right spot to drop the hotloader, otherwise - i also exported out the hotLoader now, for cases very complex

When using oneOf, HRM is never activated. This patch improved the lookup system used for determining
if CSS can and should be reloaded. There have been some other tweaks for css modules and HMR

fix #98,#80
@ScriptedAlchemy ScriptedAlchemy self-assigned this Oct 9, 2018
ScriptedAlchemy and others added 5 commits October 8, 2018 17:49
In the event users cannot get it to work, theres an example in the docs to reference
Do not break when searching through `use` or `loader` that is a function
* docs(readme): Tone of Voice clairification on what hot:true does (#113)

* fix(index.js): Support function loaders

updateWebpackConfig previously expected `use` entries to be strings or arrays, and would throw `needle.includes is not a function` errors when given a function that returns a loader object.

* Update README.md
* docs(readme): Tone of Voice clairification on what hot:true does (#113)

* Add reloadAll and cssModules to typings
@ScriptedAlchemy ScriptedAlchemy merged commit ae0f5b1 into master Oct 23, 2018
@ScriptedAlchemy ScriptedAlchemy deleted the css-module-oneof-hmr branch December 23, 2018 05:52
@faceyspacey
Copy link
Owner

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants