fix(index.js): Support function loaders #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updateWebpackConfig previously expected `use` entries to be strings or arrays, and would throw `needle.includes is not a function` errors when given a function that returns a loader object.
ScriptedAlchemy
approved these changes
Oct 9, 2018
|
published as |
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 23, 2018
* fix: Fixed HMR issue when oneOf is used When using oneOf, HRM is never activated. This patch improved the lookup system used for determining if CSS can and should be reloaded. There have been some other tweaks for css modules and HMR fix #98,#80 * fix: Applying rollback fixes to updateWebpackConfig, search loader and use object keys * fix: Adding back exported out hot loader * docs(readme): Adding example of manual hotloader implementation In the event users cannot get it to work, theres an example in the docs to reference * fix: handle functions as loaders Do not break when searching through `use` or `loader` that is a function * fix(index.js): Support function loaders (#116) * docs(readme): Tone of Voice clairification on what hot:true does (#113) * fix(index.js): Support function loaders updateWebpackConfig previously expected `use` entries to be strings or arrays, and would throw `needle.includes is not a function` errors when given a function that returns a loader object. * Update README.md * test: Fixing function-loader tests * Add reloadAll and cssModules to typings (#115) * docs(readme): Tone of Voice clairification on what hot:true does (#113) * Add reloadAll and cssModules to typings
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateWebpackConfig previously expected
useentries to be strings or arrays, and would throwneedle.includes is not a functionerrors when given a function that returns a loader object.I ran into this while using react-svg-loader:
It uses a function to return a loader object per resource, so that svgo can be instructed to give svgs unique ids.