Skip to content

Update scalajs-js-envs to 1.4.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update scalajs-js-envs to 1.4.0 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ lazy val `scalajs-env-jsdom-nodejs`: Project = project.in(file("jsdom-nodejs-env
commonSettings,

libraryDependencies ++= Seq(
"org.scala-js" %% "scalajs-js-envs" % scalaJSVersion,
"org.scala-js" %% "scalajs-env-nodejs" % scalaJSVersion,
"org.scala-js" %% "scalajs-js-envs" % MetaBuildShared.scalajsJsEnvsVersion,
"org.scala-js" %% "scalajs-env-nodejs" % MetaBuildShared.scalajsJsEnvsVersion,

"com.novocode" % "junit-interface" % "0.11" % "test",
"org.scala-js" %% "scalajs-js-envs-test-kit" % scalaJSVersion % "test"
"org.scala-js" %% "scalajs-js-envs-test-kit" % MetaBuildShared.scalajsJsEnvsVersion % "test"
)
)

Expand Down
6 changes: 6 additions & 0 deletions project/MetaBuildShared.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// this file is shared between the build and the meta-build
// the file is located in project/ and there is a system link
// to it in project/project/
object MetaBuildShared {
val scalajsJsEnvsVersion = "1.4.0"
}
2 changes: 1 addition & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.7")
addSbtPlugin("com.github.sbt" % "sbt-release" % "1.0.15")
addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.1.2")

libraryDependencies += "org.scala-js" %% "scalajs-env-nodejs" % "1.0.1"
libraryDependencies += "org.scala-js" %% "scalajs-env-nodejs" % MetaBuildShared.scalajsJsEnvsVersion

unmanagedSourceDirectories in Compile +=
baseDirectory.value.getParentFile / "jsdom-nodejs-env/src/main/scala"
1 change: 1 addition & 0 deletions project/project/MetaBuildShared.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../MetaBuildShared.scala
Copy link
Owner

@exoego exoego Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q) Why is this new file added?

It appears that scalajsJsEnvsVersion is not used in project/project/~.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because project/project/*.scala files are available to project/*.sbt files as project/*.scala files are available to *.sbt files.

Copy link
Author

@lolgab lolgab Apr 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also system-link it to project/MetaBuildShared.sbt which should be equivalent to project/project/MetaBuildShared.scala if you prefer.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exoego I can also skip this DRY attempt and have the version defined twice.
If you can, let me know what you prefer so we can merge this PR :)

Copy link
Owner

@exoego exoego Apr 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do not get it.
Again, it appears that scalajsJsEnvsVersion is not used in project/project/~.

I prefer not having unused file.
Is scalajsJsEnvsVersion used somewhere in project/project/~ ??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project/project/*.scala files are compiled together with project/*.sbt so it is used in project/plugins.sbt.

It it's the same situation when you define a project/Build.scala, you might think that it is unused in project/~ but the values are used in root build.sbt

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I delete project/project/MetaBuildShared.scala I get:

[info] welcome to sbt 1.5.3 (Homebrew Java 11.0.18)
/Users/lorenzo/scala/scala-js-env-jsdom-nodejs/project/plugins.sbt:6: error: not found: value MetaBuildShared
libraryDependencies += "org.scala-js" %% "scalajs-env-nodejs" % MetaBuildShared.scalajsJsEnvsVersion
                                                                ^
[error] Type error in expression

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah now I see.
Symlink is fine.