Skip to content

🧪 TESTS: Remove needless xfail #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2021
Merged

🧪 TESTS: Remove needless xfail #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4578de
🧪 TESTS: Remove needless xfail
hukkin Dec 1, 2021
561c224
Merge branch 'master' into no-xfail
chrisjsewell Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[build-system]
requires = ["setuptools>=46.4.0", "wheel"]
build-backend = "setuptools.build_meta"

[tool.pytest.ini_options]
xfail_strict = true
6 changes: 0 additions & 6 deletions tests/test_port/test_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ def test_commonmark_extras(line, title, input, expected):
read_fixture_file(FIXTURE_PATH.joinpath("normalize.md")),
)
def test_normalize_url(line, title, input, expected):
if title in {
"Keep %25 as is because decoding it may break urls, #720",
"Square brackets are allowed",
}:
# TODO fix failing url escaping test
pytest.xfail("url normalisation")
md = MarkdownIt("commonmark")
text = md.render(input)
assert text.rstrip() == expected.rstrip()
Expand Down