Skip to content

Make markdown_it.common.entities.entities a dict. Remove AttrDict #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Mar 31, 2021

Hey @chrisjsewell what's your thoughts on a change like this?

One test fails because of AttDict usage in mdit-py-plugins, so would need to be fixed there first.

mdit-py-plugins uses AttrDict only this one time, and doesn't use entities at all. Not sure how much or if this would break much in MyST or elsewhere though? EDIT: MyST seems to not use entities at all, and the only use of AttrDict is env related, so should be removed regardless with markdown_it_py>=1.0.0 support.

@hukkin hukkin marked this pull request as draft March 31, 2021 10:06
@hukkin
Copy link
Contributor Author

hukkin commented Mar 31, 2021

Made a PR to remove AttrDict usage from mdit-py-plugins, so that would fix the test failure here.

@hukkin
Copy link
Contributor Author

hukkin commented Mar 31, 2021

On another note, maybe entities should be defined in common/__init__.py rather than common/entities.py ? The import path would more closely resemble JS upstream then, i.e. current from markdown_it.common.entities import entities vs from markdown_it.common import entities

@hukkin hukkin changed the title Make markdown_it.common.entities.entities a dict. Remove AttrDict Make markdown_it.common.entities.entities a dict. Remove AttrDict Apr 1, 2021
@chrisjsewell
Copy link
Member

superseded by #181

@hukkin hukkin deleted the rm-attrdict branch December 3, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants