Make markdown_it.common.entities.entities
a dict. Remove AttrDict
#153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @chrisjsewell what's your thoughts on a change like this?
One test fails because of
AttDict
usage inmdit-py-plugins
, so would need to be fixed there first.mdit-py-plugins
usesAttrDict
only this one time, and doesn't useentities
at all. Not sure how much or if this would break much in MyST or elsewhere though? EDIT: MyST seems to not useentities
at all, and the only use ofAttrDict
isenv
related, so should be removed regardless withmarkdown_it_py>=1.0.0
support.