Fixed "TypeError: undefined is not an object (evaluating '$log.error.logs.push')" error in angular integration #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" error when used along with angular-mocks.
|
|
|
Thanks! We really appreciate it! |
|
We have some testing to do and then we want to push out a new release. |
|
This has been deployed (https://github.com/exceptionless/Exceptionless.JavaScript/releases/tag/v1.4.2) Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues related to
"TypeError: undefined is not an object (evaluating '$log.error.logs.push') in ./bower_components/angular-mocks/angular-mocks.js"
error when exceptionless angular integration library is used in a project with unit testing.
angular-mocks library expects a
logsproperty on $log.info, $log.warn, $log,error, $log.log and $log.debug objects and is used when $log.error()... methods are called.https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L332-L388
https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L300-L303
Since this is not defined on the $log exceptionless decorator, errors occur in unit tests using $log service.