-
-
Notifications
You must be signed in to change notification settings - Fork 23
Feature/deduplication #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
fd0f3bb
0fc7f0c
7c12490
c609e4c
1e57e9e
93b29f0
8a1ebc3
0f8261a
e41652d
b3419f1
4cfc5fa
fff0f69
09cd805
06d81f2
ef44761
e2968cc
1bbe4bf
2a35c09
f7c9b2d
b26971a
bf1baab
be062f7
63c94a1
66f40c3
cdf55c8
bb0414d
9651726
ef5f477
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,5 @@ export interface IEvent { | |
value?: number; | ||
data?: any; | ||
reference_id?: string; | ||
count?: number; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should interval have a default value (you can do defaults in typescript)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that it's there, I just wonder if the definition needs to be regenerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the definition needs to contain the default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that it generates it correctly?