Fixes #25 Add support for stringifying event data with a maxDepth #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemyjski
force-pushed
the
feature/json_stringify_depth
branch
from
aaf2b06 to
a65e7a7
Compare
ejsmith
reviewed
Mar 17, 2023
Comment on lines
+218
to
+240
| switch (typeof value) { | ||
| case "function": | ||
| return true; | ||
| case "object": | ||
| switch (Object.prototype.toString.call(value)) { | ||
| case "[object AsyncGenerator]": | ||
| case "[object Generator]": | ||
| case "[object ArrayBuffer]": | ||
| case "[object Buffer]": | ||
| case "[object DataView]": | ||
| case "[object Promise]": | ||
| case "[object WeakMap]": | ||
| case "[object WeakSet]": | ||
| return true; | ||
| } | ||
|
|
||
| // Check for buffer; | ||
| if ("writeBigInt64LE" in value) { | ||
| return true; | ||
| } | ||
|
|
||
| break; | ||
| } |
There was a problem hiding this comment.
Sure seems like we'd be better off having a list of things that we allow vs trying to keep an exhaustive list of unsupported types when new types can be added and probably different runtimes have different built in types as well. There are only so many intrinsic types that we should support.
There was a problem hiding this comment.
Yeah, we can work towards improving this. I'm assuming there will be more types over time, and we will need to optimize this some.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the most robust stringify and prune implementation out there. At minimum it's 12x all other implementations.