feat: jumpstart hyperparameters and env variables #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGuinegagne
suggested changes
Jan 7, 2022
| if region is None: | ||
| region = JUMPSTART_DEFAULT_REGION_NAME | ||
|
|
||
| assert region is not None |
There was a problem hiding this comment.
optional: to avoid assert, you can do:
_region = region if region is not None else JUMPSTART_DEFAULT_REGION_NAME| "py_version": "py3", | ||
| } | ||
| ) | ||
| assert specs1.training_ecr_specs == JumpStartECRSpecs( | ||
| { | ||
| "framework": "pytorch", | ||
| "framework_version": "1.9.0", | ||
| "framework_version": "1.5.0", |
There was a problem hiding this comment.
just curious: why these changes? Are you weakening the test here?
There was a problem hiding this comment.
I changed the base model spec
evakravi
force-pushed
the
feat/jumpstart-hyperparameters
branch
from
5eea777 to
86d97ef
Compare
evakravi
force-pushed
the
feat/jumpstart-hyperparameters
branch
from
86d97ef to
9c643e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds utilities for accessing hyperparameters and environment variables associated with JumpStart models. The functions
hyperparameters.retrieve_defaultandenvironment_variables.retrieve_defaulthave been added, which retrieve default hyperparameters (for training) and environment variables (for inference), respectively.Testing done:
The new utilities have undergone unit testing, and the values returned from the utilities are used in integration tests.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.