#606. Initial framework for hardware SPI for ESP8266.

[nkolban]

The ESP8266 jshardware source file needs prepared for more detailed implementation of SPI hardware support. This commit includes the framework for implementation of those detailed functions.

The hardware SPI source files are also introduced in this commit with the corresponding Makefile change to include them in ESP8266 compilation.

[tve]

looks like a space/tab mismatch?

[nkolban]

Yup ... sorry about that. Have corrected now.

[nkolban]

Howdy ... is there something that needs attention with this Pull Request before it can be merged? Want to make sure that it isn't waiting on something I need to attend to.

[gfwilliams]

Hi, sorry for the delay... Looks good - please could you just:

• tweak the indenting in the Makefile to match?
• add spi:1 to ESP8266_12.py - I don't see any reason not to at the moment? Anything we can do to keep them in sync for now is good.
• Swap the licence text in targets/esp8266/spi.h/c to MPLv2? You said MetalPhreak was fine with that?

[nkolban]

Requested changes made and committed.

[gfwilliams]

Thanks, I'll merge - but you know you committed quite a lot of extra stuff this time as well? Or was adding NeoPixel intentional?

https://github.com/nkolban/Espruino/commit/71d19752eea5941db68f8945d23969ba04da64c7

The AES branch is now merged too, so you could massively simplify your NeoPixel code.Literally just the following will do:

/*JSON{
 "type"     : "staticmethod",
 "class"    : "ESP8266",
 "name"     : "neopixelWrite",
 "generate" : "jswrap_ESP8266_neopixelWrite",
 "params"   : [
   ["pin", "pin", "Pin for output signal."],
   ["arrayOfData", "JsVar", "Array of LED data."]
 ]
}*/
void jswrap_ESP8266_neopixelWrite(Pin pin, JsVar *jsArrayOfData) {
  if (!jshIsPinValid(pin)) {
    jsExceptionHere(JSET_ERROR, "Pin is not valid.");
    return;
  }
  JSV_GET_AS_CHAR_ARRAY(dataPtr, dataLen, jsArrayOfData);
  if (!dataPtr) return 0;
 // ...

Note also that you can set the variable type in the JSON to pin and the conversion is done for you. Same for ints and floats too.

[nkolban]

Pure gold!!! I had no idea that the params section of JSON was more than documentation ... and had been filling it in as a good citizen by accident. I didn't know it could dynamically cast parameters ... VERY nice.

The JSV_GET_AS_CHAR_ARRAY is also nice however I had to convince myself that I could understand it. It seems to create new variables which I found an unusual side effect for a macro. I can't say it is wrong ... just unusual (to me).

I have accommodated both changes and after testing, will commit them with the next batch.

[gfwilliams]

Thanks!

Yes, I was unsure about that behaviour, but the variables always have to be the same time so it seemed to make sense to avoid duplication. Maybe not...

For the JSON, it's used for the reference, to define how the function gets called, and for autocomplete in the Web IDE.

Some info here, maybe it needs clearing up a bit though:

• https://github.com/espruino/Espruino/blob/master/README_BuildProcess.md#wrapper-files-
• https://github.com/espruino/Espruino/blob/master/scripts/common.py#L52

... by making all the type conversions automatic, Espruino cuts out on all the duplicated code that handles that so it doesn't use up much Flash. It's also removing another potential source of bugs :)