Skip to content

Fix infinite loop if repo clone is renamed #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

rtrbt
Copy link
Contributor

@rtrbt rtrbt commented Jul 15, 2022

If the repo clone directory was not named esp32-arduino-lib-builder, the script ran into an infinite loop, because the following loop
was not skipped if dname started already one level above the components and build directories.

while [[ "$dname" != "components" && "$dname" != "build" ]]; do

Then never became false.

If the repo clone directory was not named esp32-arduino-lib-builder,
the script ran into an infinite loop.
@perotom perotom mentioned this pull request Aug 23, 2022
@me-no-dev me-no-dev changed the base branch from master to release/v4.4 July 18, 2023 10:01
@me-no-dev me-no-dev changed the base branch from release/v4.4 to release/v5.1 July 18, 2023 11:17
@me-no-dev me-no-dev changed the base branch from release/v5.1 to master July 18, 2023 11:24
@me-no-dev me-no-dev merged commit 685f87d into espressif:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants