Change sntp update interval from 1 to 3 hour. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Change sntp default update interval from 1 to 6 hours. ## Impact This PR aims at reducing the amount of requests sent to the (free as-in-beer and community run) ntp time servers. The amount of requests for the ntp project should be a a lot less (per esp32) than with the current settings. ## Rationale Just from my home network with 5 esp32 controllers there are more than 100 ntp requests per day with the 1 hour update interval. The [ntp project](http://www.ntp.org/) is a community run service and open source projects should strive to minimize their impact on this service.
atanisoft
suggested changes
Nov 1, 2021
|
Sorry for the late reply @CelliesProjects ! This PR somehow evaded me... I can agree that we can change the interval to 3 hours, but why do the rest? The other two changes just limit the user. They can still define just 1 server, if that is what they need. Why do not allow them to have one over DHCP? Or define fallback? As you said, those are community servers, whose uptime is not 100% guaranteed. |
|
@me-no-dev No idea what I was thinking. -too long ago- |
|
as a side effect from time, the files no longer exist :) you would need to add that config value just once here |
me-no-dev
pushed a commit
that referenced
this pull request
Jun 14, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change sntp default update interval from 1 to 3 hours.
Impact
This PR aims at reducing the amount of requests sent to the (free as-in-beer and community run) ntp time servers.
The amount of requests for the ntp project should be a a lot less (per esp32) with this PR merged than with the current settings.
Rationale
Just from my home network with 5 esp32 controllers running, there are more than 100 ntp requests per day with the 1 hour update interval.
The ntp project is a community run service and open source projects should strive to minimize their impact on this service.
About this PR
This PR was started as espressif/arduino-esp32#5824 then moved here.