Skip to content

feat(matter): removes -DESP32=ESP32 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat(matter): removes -DESP32=ESP32 #224

merged 1 commit into from
Sep 26, 2024

Conversation

SuGlider
Copy link
Contributor

Description

removes -DESP32=ESP32 from flags/defines for V5.1

Related

None

Testing

CI

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@SuGlider
feat(matter): removes -DESP32=ESP32
764cc8d 
removes -DESP32=ESP32 from flags/defines
@SuGlider SuGlider self-assigned this Sep 26, 2024
@SuGlider SuGlider requested a review from me-no-dev September 26, 2024 12:07
@me-no-dev me-no-dev merged commit 4ae464b into master Sep 26, 2024
8 checks passed
@me-no-dev me-no-dev deleted the remove_D_ESP32_ESP32 branch September 26, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@SuGlider SuGlider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuGlider @me-no-dev