-
Notifications
You must be signed in to change notification settings - Fork 180
Using most IDF Managed Components instead of git-clone #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using most IDF Managed Components instead of git-clone #145
Conversation
Removes RainMaker and replaces "all" to get it working with WSL Ubuntu
Lib builder Managed Components for the top level (not in Arduino as IDF Component level). Includes only Tensor Flow and Deep Learning. All other managed component will be added to ESP32-Arduino repository.
@@ -187,6 +187,19 @@ for target_json in `jq -c '.targets[]' configs/builds.json`; do | |||
idf.py -DIDF_TARGET="$target" -DSDKCONFIG_DEFAULTS="$idf_libs_configs" idf_libs | |||
if [ $? -ne 0 ]; then exit 1; fi | |||
|
|||
if [ "$target" == "esp32s3" ]; then | |||
idf.py -DIDF_TARGET="$target" -DSDKCONFIG_DEFAULTS="$idf_libs_configs" srmodels_bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@me-no-dev - It sounds like CI is failing here... It works in my computer, though! :-)
-- Build files have been written to: /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/build
ninja: error: unknown target 'srmodels_bin'
ninja failed with exit code 1, output of the command is in the /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/build/log/idf_py_stderr_output_20115 and /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/build/log/idf_py_stdout_output_20115
Error: Process completed with exit code 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not nice. We need a proper workaround
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to figure out a way to fix CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@me-no-dev - I found out what is the issue here.
In order to add SR component to the CI here (current PR), I need that the PR #8842 is merged, because it adds SR to the Arduino yml file.
After SR is listed in the managed components(from Arduino side), it will run CI corretly here at Lib Builder CI.
As a way to test it, I've added SR to the local Lib Bulder yml file in a "testing" commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it shows an Arduino esp32-hal-sr.c error:
-c /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/libraries/ESP_SR/src/esp32-hal-sr.c
/home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/libraries/ESP_SR/src/esp32-hal-sr.c:10:2: warning: #warning Compatible partition must be selected for ESP_SR to work [-Wcpp]
10 | #warning Compatible partition must be selected for ESP_SR to work
| ^~~~~~~
/home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/components/arduino/libraries/ESP_SR/src/esp32-hal-sr.c:27:10: fatal error: esp_mn_speech_commands.h: No such file or directory
27 | #include "esp_mn_speech_commands.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is that we merge Arduino espressif/arduino-esp32#8842 and then check how CI will work here at Lib Builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/espressif/arduino-esp32/actions/runs/6800936891/job/18490657761?pr=8842
Specific CI for the S3 is passing fine in the Arduino PR #8842
It shall run fine here as well.
Eveidence from the CI:
[1237/1323] Building CXX object esp-idf/arduino-esp32/CMakeFiles/__idf_arduino-esp32.dir/libraries/ESP_SR/src/ESP_SR.cpp.obj
With no error.
@me-no-dev - This is the 1st output of the PACMAN when using the lastest change (it gets the Camera from GH, latest commit) Processing 23 dependencies: And after it has updated the components for the first time, it displays Camera just as the latest commit from GH: -- Building ESP-IDF components for target esp32s3 |
require: public | ||
rules: | ||
- if: "target in [esp32s3]" | ||
espressif/esp-sr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component (esp-sr) is already in Arduino component list from PR #8842.
As soon as the #8842 is merged, I'll remove it and make it run CI again.
This PR makes 2 main changes:
1- Fixes CMakeFiles and the build.sh + copy-libs.sh to work with WSL Ubuntu
2- Removes RainMaker and other git-cloned component in order to use them from the Managed Components Registry.
This change demands that Arduino Repository also change in orde to reflect the use of Managed Components.
espressif/arduino-esp32#8842