Skip to content

make Compiling with ESP-IDF 5.2.2 again #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

f-hoepfinger-hr-agrartechnik

make Compiling with ESP-IDF 5.2.2 again

Update max supported IDF version to 5.2.99 and idf dependency range to <5.3.
The commit adds overloaded connect methods with timeout support to both the Client and ESPLwIPClient classes. This enhancement allows for establishing connections with specified timeouts.
- Update the write function parameter to accept a constant uint8_t pointer for improved data integrity and security.
Changed the write function parameter to accept a constant pointer for buffer input. This modification enhances data integrity and security by preventing unintended modifications to the buffer content during writing operations.
Added a new interrupt priority setting to the I2S configuration for better control and handling of interrupts.
- Changed data mode to MSB first
- Updated master bus timing functions for better performance
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add overloaded connect methods with timeout support":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update I2C data mode and master bus timing settings":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update I2S configuration with new interrupt priority setting":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update write function parameter to const pointer":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update write function parameter to const uint8_t pointer.":
    • body's lines must not be longer than 100 characters
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message "gitflow-feature-stash: patch-1":
    • summary looks empty
    • type/action looks empty
    • body must have leading blank line

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 7 commits (simplifying branch history).
⚠️ The Pull Request description looks very brief, please check if more details can be added.

👋 Hello f-hoepfinger-hr-agrartechnik, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against daa30cd

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit daa30cd.

♻️ This comment has been updated with latest results.

@lucasssvaz
Copy link
Collaborator

lucasssvaz commented Jun 17, 2024

This cannot be accepted as current master branch tracks IDF version v5.1. For now, the current pla is to skip v5.2 and go straight for v5.3 in the future, as it will include support for ESP32-P4.

@lucasssvaz lucasssvaz added the Resolution: Wontfix Arduino ESP32 team will not fix the issue label Jun 17, 2024
@me-no-dev me-no-dev closed this Jun 18, 2024
@Jason2866
Copy link
Collaborator

@f-hoepfinger-hr-agrartechnik Based on this PR i added a few missing things to make everything compile with the Arduino Lib Builder. You can use the Tasmota Arduino framework compiled with IDF 5.2.2 with Platformio by using this Platform

platform = https://github.com/Jason2866/platform-espressif32/releases/download/2024.07.20/platform-espressif32.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Wontfix Arduino ESP32 team will not fix the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants