Skip to content

add ETH PHY Jl1101 #9474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add ETH PHY Jl1101 #9474

wants to merge 2 commits into from

Conversation

Jason2866
Copy link
Collaborator

needs IDF PR espressif/esp-idf#13572 merged first.
@me-no-dev

@Jason2866 Jason2866 added the Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "add ETH_PHY_JL1101":
    • summary looks empty
    • type/action looks empty
  • the commit message "add ETH_PHY_JL1101":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "JL1101" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello Jason2866, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1860ba8

@lucasssvaz lucasssvaz added Status: Blocked by ESP-IDF and removed Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first labels Apr 10, 2024
@me-no-dev
Copy link
Member

@Jason2866 let's close this for now and once your driver is merged in the extra drivers, you can open new request here and in the lib-builder to add the component for it.

@me-no-dev me-no-dev closed this Apr 15, 2024
@Jason2866 Jason2866 deleted the JL1101 branch April 15, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants