Skip to content

Feature/ppp modem support #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

Feature/ppp modem support #9464

wants to merge 28 commits into from

Conversation

me-no-dev
Copy link
Member

@me-no-dev me-no-dev commented Apr 8, 2024

LibBuilder PR: espressif/esp32-arduino-lib-builder#169

Current state:

Waiting to attach 12.3s
Name: SIMCOM_SIM800L
IMEI: 867273020838111
State: 1
Attached: 1
Operator: GLOBUL
IMSI: 284050052659410
RSSI: 31
BER: 0
[ 15748][V][NetworkInterface.cpp:66] _onIpEvent(): ppp Got New IP: 10.217.139.148 MASK: 255.255.255.255 GW: 10.64.64.64
[ 15759][V][NetworkEvents.cpp:125] checkForEvent(): Network Event: 47 - PPP_GOT_IP
[ 15759][V][PPP.cpp:107] _onPppEvent(): PPP Driver Event 0: No error.
[ 15773][V][PPP.cpp:83] _onPppArduinoEvent(): PPP Arduino Event 47: PPP_GOT_IP
PPP Got IP[2]: 'ppp' (pp1)
*ppp: <UP> (,PPP)
      ether 00:00:00:00:00:00
      inet 10.217.139.148 netmask 255.255.255.255 broadcast 10.64.64.64
      gateway 10.64.64.64 dns 85.118.197.144

[ 15791][V][NetworkEvents.cpp:125] checkForEvent(): Network Event: 45 - PPP_CONNECTED
[ 15805][V][PPP.cpp:83] _onPppArduinoEvent(): PPP Arduino Event 45: PPP_CONNECTED
PPP Connected

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add PPP to configurations":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add esp_modem component":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add example sketch":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add initial PPP Modem support":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add more access methods":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add support for changing baud rate":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add sync and update reset and wait logic":
    • summary looks empty
    • type/action looks empty
  • the commit message "Better event handling":
    • summary looks empty
    • type/action looks empty
  • the commit message "Change return value on some methods":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix PPP.end()":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix build error":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix string input methods and add direct AT command API":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF d23b7a0361":
    • summary looks empty
    • type/action looks empty
  • the commit message "Improve example and add some comments to the header":
    • summary looks empty
    • type/action looks empty
  • the commit message "LWIP_PPP: Fix compilation (#9484)":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "Rename Method":
    • summary looks empty
    • type/action looks empty
  • the commit message "Style Checker and Pre-commit hook CI (#9132)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update CMakeLists.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update libs and API":
    • summary looks empty
    • type/action looks empty
  • the commit message "add change to re-trigger the CI":
    • summary looks empty
    • type/action looks empty
  • the commit message "trigger CI":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 28 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 1777), you might consider splitting it into smaller PRs

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2fc7462

@me-no-dev
Copy link
Member Author

@P-R-O-C-H-Y this PR uses different libs and will cause size difference in the firmware. Use it to test comparison with master

@me-no-dev me-no-dev added Area: LIB Builder Depends on Lib Builder Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first labels Apr 10, 2024
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC2 milestone Apr 12, 2024
@VojtechBartoska VojtechBartoska added the Area: WiFi Issue related to WiFi label Apr 15, 2024
* Add Config

* Add Cache and remove pre-commit action

* [pre-commit.ci lite] apply automatic fixes

* Remove freeze

* Fix

* Update action

* Use latest stable Python 3 version

* Improve caching

* Improve cache tag

* Improve bot message

* Fix flake and make Vale manual

* Add filter

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <[email protected]>
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Apr 15, 2024
@me-no-dev me-no-dev removed the Status: Pending Merge Pull Request is ready to be merged label Apr 15, 2024
@me-no-dev me-no-dev closed this Apr 15, 2024
@me-no-dev me-no-dev reopened this Apr 15, 2024
@me-no-dev me-no-dev closed this Apr 15, 2024
@me-no-dev me-no-dev deleted the feature/ppp_modem_support branch April 15, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LIB Builder Depends on Lib Builder Area: WiFi Issue related to WiFi Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first
Projects
Development

Successfully merging this pull request may close these issues.

4 participants