backports HWCDC to v2.0.15 #9462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
me-no-dev
reviewed
Apr 8, 2024
me-no-dev
reviewed
Apr 8, 2024
me-no-dev
reviewed
Apr 8, 2024
me-no-dev
reviewed
Apr 8, 2024
me-no-dev
reviewed
Apr 8, 2024
me-no-dev
reviewed
Apr 8, 2024
|
Looks good to me. I do not see anything obvious that is bad, apart from the few nitpicks outlined above |
SuGlider
commented
Apr 8, 2024
SuGlider
commented
Apr 8, 2024
SuGlider
commented
Apr 8, 2024
Done. |
P-R-O-C-H-Y
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
@SuGlider Looking good 👍
Please just fix the #endif comment.
|
@me-no-dev / @VojtechBartoska - Ready for merging and releasing 2.0.15 |
|
On an Adafruit Feather ESP32-S2 Serial.print() works WITHOUT a Serial.begin() ??!! |
schlimmchen
added a commit
to hoylabs/OpenDTU-OnBattery
that referenced
this pull request
Jun 21, 2024
the "serial console" over USB would be garbled badly after switching to "platform = [email protected]". this did not happen to the upstream version of MessageOutput. we used Serial.flush(), which seemed to be good in the respective context. however, the changes in github.com/espressif/arduino-esp32/pull/9462 made flush() detrimental. we remove the use of flush(), as it seems not to be required (in particular, the upstream project does not use it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backports all changes done in Core 3.0.0 to 2.0.15.
When selecting
USB CDC On Boot: EnabledandUSB Mode: Hardware CDC and JTAG,Serialwill be the USB HW CDC port.Changes/Fixes:
while(Serial);will only return when HW CDC is connected to a Serial Monitor.Serial.end();will stop HW CDC driver and disable USB Host enumerationSerial.begin()will correctly enumerate the CDC portSerial.isPlugged()will returntruewhenever USB port is plugged and Host has enumerate the CDC portSerial.isConnected()wil returntruewhenever USB CDC is connected to a Serial Terminal and a session has statedSerial.setTxTimeoutMs(time_ms)can be used to avoid failing writing within long data buffers due to Host delayA new example is here provided.
Tests scenarios
Tested with ESP32-S3 and ESP32-C3 using the new example.
Tested using a modified version of code provided in #9401
Related links
N/A