-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Handle large octet-stream (master branch) #9440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello nathannau, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
9cae991
to
b29efc4
Compare
@nathannau Please pull the commits and don't force push over them. I had already fixed the CI errors for the example. |
Following the instruction on the readme causes the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example doesn't work as expected: curl: (55) Send failure: Broken pipe
in the example folder you need to add an empty file with name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an empty .skip.esp32h2
file alongside your example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, tested also SDWebServer example with no issues.
@nathannau Please add the skip file for H2. Thanks
* Handle large octet-stream * Add exemple Upload Huge File * Remove unuse function printDirectory * Fix upload path * Simplify and generalize the body parsing. * Create .skip.esp32h2 --------- Co-authored-by: me-no-dev <[email protected]>
Issue
In scenarios where the request body size exceeds the available RAM, the ESP fails to allocate sufficient memory to process the request in one go.
Change
Now, when the "Content-Type" of the request is "application/octet-stream", it will attempt to call the "ufn" function of the handler, similar to how it handles multipart requests.
Code Example: