Skip to content

Added pin check in ETH examples to avoid redefinition #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2024
Merged

Added pin check in ETH examples to avoid redefinition #9242

merged 1 commit into from
Feb 14, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Feb 13, 2024 •
edited
Loading

Description of Change

Added check for ETH_PHY_TYPE to avoid Ethernet pins redefinition in sketch, if ETH pins are defined in variants pins_arduino.h. Also renamed pins defines in examples, to match empales of defines in ETH.h.

Tests scenarios

Compiled all ETH examples + tested variant with ETH pins defined.

Related links

Closes #9241

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 13, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Libraries Issue is related to Library support. Status: Review needed Issue or PR is awaiting review labels Feb 13, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0-RC1 milestone Feb 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7cd6b53

@me-no-dev me-no-dev merged commit 90036a2 into espressif:master Feb 14, 2024
@Stanimir-Petev Stanimir-Petev mentioned this pull request Feb 19, 2024
Merged
me-no-dev pushed a commit that referenced this pull request Feb 21, 2024
@Stanimir-Petev @P-R-O-C-H-Y
Added support for 2 new Olimex boards and updated 3 existing ones (#9264
e18d8b9 
)

* Added new Olimex boards

Added variants for ESP32-H2-DevKit-LiPo and ESP32-SBC-FabGL boards

* Changes on the ESP32-POE and POE-ISO

Added menu for selection of the:
1) PSRAM enabled/disabled
2) Flash size 4/16 MB
3) Flash mode QIO/DIO
4) Partition Scheme additional options

* Updated pins_arduino.h for ESP32 POE, POE-ISO and Gateway

Due to the latest changes in the ethernet library/examples (#9242) full package of definitions of the ethernet macros is for each board that has non-default values.
For POE and POE-ISO is added a preprocessor condition #if defined BOARD_HAS_PSRAM due to our specific hardware because GPIO 16 and 17 are in use when PSRAM is enabled.

* Update boards.txt

Removed the  -mfix-esp32-psram-cache-issue -mfix-esp32-psram-cache-strategy=memw 
fix flags as suggested by Jason2866 and me-no-dev

* Update boards.txt

Reverted changes for ESP32-POE and ESP32-POE-ISO

* Update boards.txt

Rearrange of the enable/disable entries of the PSRAM option for ESP32-SBC-FabGL to be enabled by default.

---------

Co-authored-by: Jan Procházka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Libraries Issue is related to Library support. Status: Review needed Issue or PR is awaiting review
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Ethernet macros changes is it a bug?
2 participants
@P-R-O-C-H-Y @me-no-dev