Skip to content

IDF Component YAML fixes - Add license, include example + readme in ESP Registry #9162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

IDF Component YAML fixes - Add license, include example + readme in ESP Registry #9162

merged 1 commit into from
Jan 23, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes:

  • adding IDF component example (Hello_world) to the ESP Registry.
  • issue with no license provided
  • adds ReadMe file

Tests scenarios

Tested by uploading component under personal namespace.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Arduino as ESP-IDF component Issues about Arduino used as component in ESP-IDF label Jan 23, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0-RC1 milestone Jan 23, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

Warnings
⚠️

The source branch "ESP-registry-fix" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b19aee1

@me-no-dev me-no-dev merged commit 9258a8c into espressif:master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Arduino as ESP-IDF component Issues about Arduino used as component in ESP-IDF
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@P-R-O-C-H-Y @me-no-dev