-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Adds SparkFun Pro Micro C3 Variant File #9158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello edspark, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Adds SparkFun Pro Micro ESP32-C3 variant to boards.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edspark PTAL on my comments.
@@ -0,0 +1,58 @@ | |||
#ifndef Pins_Arduino_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix variant folder name to lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compilation still fails. The folder name was not changed in the last commit. PTAL @edspark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually fixed this time, I'm not sure why it didn't take the first time.
Description of Change
Adds the SparkFun Pro Micro C3 Variant File and adds the board to boards.txt.
Tests scenarios
Tested with v2.0.11 of the Espressif ESP32 Arduino Core.
Related links
This is the related product