-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fixes Malloc call in WebServer code #9012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes `malloc()` call preventing it from using function pointer reference instead of actually calling the function itself.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
My approval means nothing, but this is clearly the most correct, least risky change to fix it.
I agree with this bugfix. Thanks! |
Description of Change
This fixes a wrong (but "valid") call for
malloc()
.C:/Users/user/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp:138:54: warning: pointer to a function used in arithmetic [-Wpointer-arith]
138 | char *toencode = (char *)malloc[toencodeLen + 1];
| ^
cc1plus.exe: warning: pointer to a function used in arithmetic [-Wpointer-arith]
Tests scenarios
Just CI
Related links
Fixes #9007