Skip to content

[CI] ESP32 Arduino CI fixes for Windows runner #8991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes CI build on Windows runners, which did not failed on compilation error.
Also replaced BLE example with the correct one + simplified example selection across multiple SOCs, as the sketch_utils.sh build() now checks for the skip file.

Tests scenarios

CI passes

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0-RC1 milestone Dec 13, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 13, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the ci_windows_runner_build_fix branch from 59487d0 to cd1432b Compare December 13, 2023 09:34
Copy link
Contributor

github-actions bot commented Dec 13, 2023

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against cd1432b

@me-no-dev me-no-dev merged commit c5297bf into espressif:master Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants