Skip to content

Makes MP3 header files public for I2S code #8868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Nov 10, 2023

Description of Change

Arduino I2S uses MP3 header file and it fails when Arduino is built as IDF component.
This fixes it by making it public and exporting its header files to the I2S code and examples.

project/main/idf_component.yml:

dependencies:
  # Required IDF version
  idf: ">=5.1"
  espressif/arduino-esp32:
    version: "*"
    git: https://github.com/espressif/arduino-esp32.git
    require: public

Tests scenarios

Build any sketch using Arduino as IDF component and with Arduino as Managed Component in the idf_component.yml file.

Related links

None

@SuGlider SuGlider added this to the 3.0.0 milestone Nov 10, 2023
@SuGlider SuGlider self-assigned this Nov 10, 2023
@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Nov 10, 2023
@SuGlider SuGlider requested a review from me-no-dev November 10, 2023 21:13
@me-no-dev me-no-dev merged commit bf17d0e into espressif:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

2 participants