Skip to content

Fix linker failure when using BluetoothSerial on latest release with Arduino as Component. #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix linker failure when using BluetoothSerial on latest release with Arduino as Component. #8784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b8c75f
Fix linker failure when using BluetoothSerial on latest release with …
blackhack Oct 19, 2023
c3124b8
Merge branch 'espressif:master' into BTSerial-build-fix
blackhack Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions libraries/BluetoothSerial/src/BTAdvertisedDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ class BTAdvertisedDevice {
public:
virtual ~BTAdvertisedDevice() = default;

virtual BTAddress getAddress();
virtual uint32_t getCOD() const;
virtual std::string getName() const;
virtual int8_t getRSSI() const;
virtual BTAddress getAddress() = 0;
virtual uint32_t getCOD() const = 0;
virtual std::string getName() const = 0;
virtual int8_t getRSSI() const = 0;


virtual bool haveCOD() const;
virtual bool haveName() const;
virtual bool haveRSSI() const;
virtual bool haveCOD() const = 0;
virtual bool haveName() const = 0;
virtual bool haveRSSI() const = 0;

virtual std::string toString();
virtual std::string toString() = 0;
};

class BTAdvertisedDeviceSet : public virtual BTAdvertisedDevice {
Expand Down
6 changes: 3 additions & 3 deletions libraries/BluetoothSerial/src/BTScan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ class BTScanResults {
public:
virtual ~BTScanResults() = default;

virtual void dump(Print *print = nullptr);
virtual int getCount();
virtual BTAdvertisedDevice* getDevice(int i);
virtual void dump(Print *print = nullptr) = 0;
virtual int getCount() = 0;
virtual BTAdvertisedDevice* getDevice(int i) = 0;
};

class BTScanResultsSet : public BTScanResults {
Expand Down