Skip to content

I2S - Revert espressif/esp-idf@73ca054 to fix I2S crackling #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Commit espressif/esp-idf@73ca054 introduced crackling in the I2S communication (as discussed in #8467). This PR aims to revert the changes by replacing the libdriver.a file for each board with one the reverted changes.

Each libdriver.a file was generated by the following steps:

1 - Cloned ESP-IDF and checked out tag v4.4.5;
2 - Reverted commit;
3 - Added Arduino as an ESP-IDF component;
4 - Copied tools/sdk/<CHIP>/sdkconfig to IDF project folder;
5 - Compiled using idf.py build;
6 - Copied <PROJECT_FOLDER>/build/esp-idf/driver/libdriver.a to tools/sdk/<CHIP>/lib/libdriver.a.

Tests scenarios

Tested by @harbaum on ESP32-DevKitC on #8467.

Related links

Closes #8467.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@lucasssvaz
Copy link
Collaborator Author

@harbaum Could you please double-check if this is working as expected ? Thanks in advance!

@lucasssvaz lucasssvaz marked this pull request as draft August 28, 2023 19:23
@lucasssvaz
Copy link
Collaborator Author

Ehh, the CI is failing. I probably did something wrong when building the libs 😴

@me-no-dev me-no-dev changed the base branch from master to release/v2.x August 29, 2023 06:54
@me-no-dev
Copy link
Member

you targeted the wrong branch as beginning. Start clean from branch release/v2.x, overwrite the libs and submit another PR

@me-no-dev me-no-dev closed this Aug 29, 2023
@Jason2866
Copy link
Collaborator

Jason2866 commented Aug 29, 2023

Mhh, imho a dirty way to fix and should not be Merged! It is not working when compiling Arduino as component of IDF. The revert of IDF commit espressif/esp-idf@73ca054 is nowhere in an official source / branch.
There is no possibility to do a reproducible build of the Arduino libs!
There is only one way. Fixing the issue in IDF or Arduino source code and merging this fix to the repo!
@lucasssvaz @me-no-dev

@me-no-dev
Copy link
Member

@Jason2866 in our case we can not wait for those changes to trickle down to IDF v4.4, so we will just fix it for the IDE users (and PIO users that would use the released version). While not perfect in general, it would be good for all of our IDE and package users.

Jason2866 referenced this pull request in tasmota/esp-idf Aug 29, 2023
@lucasssvaz lucasssvaz deleted the bugfix/i2s_noise branch August 29, 2023 14:51
@lucasssvaz
Copy link
Collaborator Author

@me-no-dev I forgot I could've just fixed the commit and reopened it. I ended up creating another PR (#8583). My bad 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crackling sound on i2s with internal DAC since 2.0.10
5 participants