-
Notifications
You must be signed in to change notification settings - Fork 7.6k
I2S - Revert espressif/esp-idf@73ca054 to fix I2S crackling #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed duplicate MDNS.begin() call in example
@harbaum Could you please double-check if this is working as expected ? Thanks in advance! |
Ehh, the CI is failing. I probably did something wrong when building the libs 😴 |
you targeted the wrong branch as beginning. Start clean from branch |
Mhh, imho a dirty way to fix and should not be Merged! It is not working when compiling Arduino as component of IDF. The revert of IDF commit espressif/esp-idf@73ca054 is nowhere in an official source / branch. |
@Jason2866 in our case we can not wait for those changes to trickle down to IDF v4.4, so we will just fix it for the IDE users (and PIO users that would use the released version). While not perfect in general, it would be good for all of our IDE and package users. |
@me-no-dev I forgot I could've just fixed the commit and reopened it. I ended up creating another PR (#8583). My bad 😞 |
Description of Change
Commit espressif/esp-idf@73ca054 introduced crackling in the I2S communication (as discussed in #8467). This PR aims to revert the changes by replacing the
libdriver.a
file for each board with one the reverted changes.Each
libdriver.a
file was generated by the following steps:1 - Cloned ESP-IDF and checked out tag v4.4.5;
2 - Reverted commit;
3 - Added Arduino as an ESP-IDF component;
4 - Copied
tools/sdk/<CHIP>/sdkconfig
to IDF project folder;5 - Compiled using
idf.py build
;6 - Copied
<PROJECT_FOLDER>/build/esp-idf/driver/libdriver.a
totools/sdk/<CHIP>/lib/libdriver.a
.Tests scenarios
Tested by @harbaum on ESP32-DevKitC on #8467.
Related links
Closes #8467.