Skip to content

BT serial: SSP improvements, added missing events #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

PilnyTomas
Copy link
Contributor

@PilnyTomas PilnyTomas commented Jul 24, 2023

Added missing events
Added method to remove cached devices.
Renamed, clarified, and extended usage of SSP API + example
Fixed support for legacy pairing (fixed PIN) - must use as IDF component and disable CONFIG_BT_SSP_ENABLED
related #4566

Including fix for #8448

@PilnyTomas PilnyTomas self-assigned this Jul 24, 2023
@PilnyTomas PilnyTomas requested a review from SuGlider July 24, 2023 12:06
@PilnyTomas PilnyTomas marked this pull request as ready for review August 4, 2023 12:28
@VojtechBartoska VojtechBartoska changed the title Draft: BT serial fixes and updates BT serial: SSP example improvements, Legacy pairing removed, missing events Aug 7, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0 milestone Aug 7, 2023
@PilnyTomas PilnyTomas changed the title BT serial: SSP example improvements, Legacy pairing removed, missing events BT serial: SSP improvements, added missing events Aug 9, 2023
@VojtechBartoska VojtechBartoska self-assigned this Aug 15, 2023
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review is mostly nit-picks. I couldn't get the BT to work with the provided instructions. Please double check if it is working or my setup is faulty. Also squash the commits at the end, please.

Comment on lines +26 to +29
#### ESP32

You can flash one of the ESP32 with the example [`SerialToSerialBTM`](https://github.com/espressif/arduino-esp32/blob/master/libraries/BluetoothSerial/examples/SerialToSerialBTM/SerialToSerialBTM.ino) (the Master) and another ESP32 with [`SerialToSerialBT`](https://github.com/espressif/arduino-esp32/blob/master/libraries/BluetoothSerial/examples/SerialToSerialBT/SerialToSerialBT.ino) (the Slave).
Those examples are preset to work out-of-the-box but they should be scalable to connect multiple Slaves to the Master.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried following these instructions but couldn't get it to work. I am using two ESP32-DevKitC V4. Did I do something wrong or is it broken somehow ?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is really strange... for me, it is also not working. However, I can connect to the slave from my smartphone.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, using my smartphone I also managed to connect. There might be something weird happening in the master sketch.

@me-no-dev me-no-dev changed the base branch from esp-idf-v5.1-libs to master October 5, 2023 13:35
@me-no-dev me-no-dev changed the base branch from master to esp-idf-v5.1-libs October 5, 2023 13:35
@me-no-dev
Copy link
Member

Closed in favor of #8723

@me-no-dev me-no-dev closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BT&Wifi BT & Wifi related issues
Projects
Development

Successfully merging this pull request may close these issues.

4 participants