-
Notifications
You must be signed in to change notification settings - Fork 7.6k
BT serial: SSP improvements, added missing events #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review is mostly nit-picks. I couldn't get the BT to work with the provided instructions. Please double check if it is working or my setup is faulty. Also squash the commits at the end, please.
#### ESP32 | ||
|
||
You can flash one of the ESP32 with the example [`SerialToSerialBTM`](https://github.com/espressif/arduino-esp32/blob/master/libraries/BluetoothSerial/examples/SerialToSerialBTM/SerialToSerialBTM.ino) (the Master) and another ESP32 with [`SerialToSerialBT`](https://github.com/espressif/arduino-esp32/blob/master/libraries/BluetoothSerial/examples/SerialToSerialBT/SerialToSerialBT.ino) (the Slave). | ||
Those examples are preset to work out-of-the-box but they should be scalable to connect multiple Slaves to the Master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is really strange... for me, it is also not working. However, I can connect to the slave from my smartphone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, using my smartphone I also managed to connect. There might be something weird happening in the master sketch.
libraries/BluetoothSerial/examples/DiscoverConnect/DiscoverConnect.ino
Outdated
Show resolved
Hide resolved
libraries/BluetoothSerial/examples/SerialToSerialBT/SerialToSerialBT.ino
Outdated
Show resolved
Hide resolved
libraries/BluetoothSerial/examples/SerialToSerialBT/SerialToSerialBT.ino
Outdated
Show resolved
Hide resolved
libraries/BluetoothSerial/examples/bt_remove_paired_devices/bt_remove_paired_devices.ino
Outdated
Show resolved
Hide resolved
libraries/BluetoothSerial/examples/bt_remove_paired_devices/bt_remove_paired_devices.ino
Outdated
Show resolved
Hide resolved
Closed in favor of #8723 |
Added missing events
Added method to remove cached devices.
Renamed, clarified, and extended usage of SSP API + example
Fixed support for legacy pairing (fixed PIN) - must use as IDF component and disable
CONFIG_BT_SSP_ENABLED
related #4566
Including fix for #8448