Skip to content

Add board: Nebula S3 #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 31, 2023
Merged

Add board: Nebula S3 #8257

merged 9 commits into from
May 31, 2023

Conversation

DocMonster7
Copy link
Contributor

Description

A variant of ESP32-S3 development board created with sole focus on hobbyist with on board IMU which is MPU-6050 and
WS2812B LED with Battery connector.

Schematic

Schematic_Nebula V1_2023-05-26

Boards

Nebula s3

@CLAassistant
Copy link

CLAassistant commented May 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this May 29, 2023
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes May 29, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocMonster7 PTAL on my comment.

@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Peripherals API Relates to peripheral's APIs. Resolution: Awaiting response Waiting for response of author and removed Area: Peripherals API Relates to peripheral's APIs. labels May 29, 2023
@DocMonster7
Copy link
Contributor Author

@P-R-O-C-H-Y Please review changes made.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented May 29, 2023 •
edited
Loading

@DocMonster7 It seems you kind of changed whole boards.txt file by commit 306de8e. Can't load the diffs.
23,467 additions, 23,467 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

@DocMonster7
Copy link
Contributor Author

Sorry about that, I will try to resolve it using my local client and then push the changes instead of the web editor

@P-R-O-C-H-Y
Copy link
Member

Looks good now, but please change the board to UPPERCASE -> NebulaS3 to NEBULAS3. Thanks

@DocMonster7
Copy link
Contributor Author

I have made the requested changes. Have a look.

@DocMonster7 DocMonster7 requested a review from P-R-O-C-H-Y May 29, 2023 11:28
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now :)

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels May 29, 2023
@me-no-dev me-no-dev merged commit 0034a43 into espressif:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DocMonster7 @CLAassistant @P-R-O-C-H-Y @me-no-dev