Provisioning fix and upgrades #8209
Conversation
libraries/WiFiProv/src/WiFiProv.cpp
Outdated
| @@ -26,6 +26,7 @@ | |||
| #include <esp_wifi.h> | |||
| #include <esp_event.h> | |||
| #include <esp32-hal.h> | |||
| #include "qrcode.h" | |||
There was a problem hiding this comment.
you should check if that include exists and only then include and provide the new function. When building as component and qrcode component is not additionally installed, compilation will fail: https://github.com/espressif/arduino-esp32/actions/runs/4989420314/jobs/8933324447?pr=8209#step:4:1408
There was a problem hiding this comment.
I was expecting this to be available for all SoCs, I can see that is not, but do not understand why?
How can I test it?
There was a problem hiding this comment.
it exists from the lib-builder, because it's installed with RainMaker, but as clean IDF+Arduino-as-component it does not exist for ANY chip.
There was a problem hiding this comment.
Should be resolved - CI passed
Based on issue #7748
The main problem is simply case size for the device name:
The IDF example is using upper case:
const char *ssid_prefix = "PROV_";line 210While the Arduino is using lower case (only the first letter is upper case):
arduino-esp32/libraries/WiFiProv/examples/WiFiProv/WiFiProv.ino
Line 50 in 3ec5f4e
This PR changes the device name to the same as the IDF name and also to what is expected by the app on default settings.
This should remove the confusion for first-time users.
This PR also added function for printing QR code (simply copied from the IDF example)
This PR also updates the README file.