-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Apply this change to 2.0.9 #8131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I was using the FastLED library and it was complaining about F_CPU not being defined. So, I just noticed that it is not defined for the ESP32-S3 module. So I made this change in the header file and it compiled. Therefore I wanted to propose this change to the HAL library to improve compatibility. Thank you for your time.
Works for ESP32, ESP32C3, ESP32S2, ESP32S3
Necessary for ESP32 Arduino Core 2.0.x based on IDF 4.4
|
@me-no-dev - |
@SuGlider if it's in |
It was already in |
@SuGlider you have an extra contributor that is blocking the license agreement |
I might have an idea of what went wrong... 2.0.9 will be fine |
@SuGlider can we change a PR title to something more specific? Right now, it's without any meaning for e.g. Release notes, thanks. |
Suggested title: "Fix F_CPU for all SoCs". |
Description of Change
This change is missing in 2.0.9 (master).
Fixes F_CPU for all SoC.
Tests scenarios
Related links
#Fix #8005
#7913