Skip to content

Fixed missing upload.maximum_size for ESP32Wrover and ESP32WroverKit #8078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fixed missing upload.maximum_size for ESP32Wrover and ESP32WroverKit #8078

merged 3 commits into from
Apr 17, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

ESP32Wrover and ESP32WroverKit were missing upload.maximum_size for default_8MB partition scheme.
Also formatted ESP32WroverKit, so now its clear to read the code.

Tests scenarios

Checked all boards in boards.txt which have default_8MB partition scheme.

Related links

Closes #8026

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Apr 14, 2023
@VojtechBartoska VojtechBartoska added this to the 2.0.8 milestone Apr 14, 2023
atanisoft
atanisoft reviewed Apr 14, 2023
View reviewed changes
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from atanisoft April 17, 2023 10:21
@me-no-dev me-no-dev merged commit 248807f into espressif:master Apr 17, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the esp32wrover-partition-fix branch April 19, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanisoft atanisoft atanisoft approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
None yet
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.8
Development

Successfully merging this pull request may close these issues.

Maximum sketch size incorrect on "ESP32 Wrover Kit (all versions)"
4 participants
@P-R-O-C-H-Y @atanisoft @me-no-dev @VojtechBartoska