Skip to content

new variant Seeed XIAO_ESP32S3 #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Conversation

Maxwelltoo
Copy link
Contributor

Description of Change

new variant Seeed XIAO_ESP32S3

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v2.0.2 with Seeed XIAO_ESP32S3 Board

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maxwelltoo please take a look on my comments.

@P-R-O-C-H-Y P-R-O-C-H-Y added Resolution: Awaiting response Waiting for response of author and removed Status: Review needed Issue or PR is awaiting review labels Apr 3, 2023
@Maxwelltoo
Copy link
Contributor Author

@P-R-O-C-H-Y Thanks! I noticed these issues and addressed them one by one in the latest commit.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Apr 4, 2023
@me-no-dev me-no-dev merged commit 298442d into espressif:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants