Avoid starting AP Mode even when the password is too short #7832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrengineer7777
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Using Arduino 2.0.6 with the WiFiAccessPoint example, if the password is changed to have between 1 and 7 characters, an error message is sent, but even though the AP starts to work.
It will start with a different SSID and no password, which should not happen given that the
WiFiAPClass::softAP()returnedfalseand failed with an error message.This PR fixes it by changing the order of the parameter verification to happen before setting the AP mode.
Tests scenarios
Tested with ESP32
Related links
Fix #7831