Skip to content

Fix BluetoothSerial compilation caused by upstream change #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

me-no-dev
Copy link
Member

Fixes: #7675

The signature of esp_spp_cb_t has changed in recent ESP-IDF v4.4.3, so this fix targets to accomodate that change in Arduino

Fixes: #7675

The signature of `esp_spp_cb_t` has changed in recent ESP-IDF v4.4.3, so this fix targets to accomodate that change in Arduino
@me-no-dev me-no-dev self-assigned this Jan 9, 2023
@me-no-dev me-no-dev added this to the 2.0.7 milestone Jan 9, 2023
Copy link
Collaborator

@mrengineer7777 mrengineer7777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixes call to esp_spp_register_callback() in BluetoothSerial::_init_bt().

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
based on
typedef void (*esp_spp_cb_t)(esp_spp_cb_event_t event, esp_spp_cb_param_t *param);

@SuGlider SuGlider self-requested a review January 11, 2023 03:26
@dragonerix
Copy link

Can someone help me? in my code is:

SerialBT.register_callback(callback);
void callback(esp_spp_cb_event_t event, esp_spp_cb_param_t *param) {}

but error is 'BluetoothSerial::register_callback(void (&)(esp_spp_cb_event_t, esp_spp_cb_param_t*))'

how can I repair it? Thank you.

@me-no-dev me-no-dev merged commit d158aa6 into master Jan 12, 2023
@me-no-dev me-no-dev deleted the bugfix/bt_spp_callback branch January 12, 2023 07:55
@me-no-dev
Copy link
Member Author

@dragonerix the fix is in this pull request (that is now merged in master) and will be available in 2.0.7 shortly

@seconika
Copy link

Hi, Any news regarding this? I have this error and the "fix" do not work for me..

@VojtechBartoska
Copy link
Contributor

@seconika Can you please explain what is your issue on your side? You can open a new issue for that and link this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
7 participants