-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix BluetoothSerial compilation caused by upstream change #7681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes: #7675 The signature of `esp_spp_cb_t` has changed in recent ESP-IDF v4.4.3, so this fix targets to accomodate that change in Arduino
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fixes call to esp_spp_register_callback() in BluetoothSerial::_init_bt().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
based on
typedef void (*esp_spp_cb_t)(esp_spp_cb_event_t event, esp_spp_cb_param_t *param);
Can someone help me? in my code is: SerialBT.register_callback(callback); but error is 'BluetoothSerial::register_callback(void (&)(esp_spp_cb_event_t, esp_spp_cb_param_t*))' how can I repair it? Thank you. |
@dragonerix the fix is in this pull request (that is now merged in master) and will be available in 2.0.7 shortly |
Hi, Any news regarding this? I have this error and the "fix" do not work for me.. |
@seconika Can you please explain what is your issue on your side? You can open a new issue for that and link this Pull Request. |
Fixes: #7675
The signature of
esp_spp_cb_t
has changed in recent ESP-IDF v4.4.3, so this fix targets to accomodate that change in Arduino