[Chore] Add error name to EEPROMClass commit method's error log #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jovanfrandika
force-pushed
the
master
branch
from
ee4a756 to
162f279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Please describe your proposed Pull Request and it's impact.
I had a hard time figuring out why EEPROM kept failing when I tried to commit, so I tried to make a small improvement by adding the error name to the err log, and I finally found my answer. With this change, I hope it'll make the debugging experience much better.
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
I have tested this with ESP32
Related links
Please provide links to related issue, PRs etc.