Skip to content

Added onDisconnect with gatt parameters to BLEServerCallbacks, equivalent to the existing onConnect #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

RM-Alltrons
Copy link
Contributor


Description of Change

This change adds a onDisconnect with parameters to BLEServerCallbacks, equivalent to onDisconnect, which allows the code to know which (of the multiple connections) is disconnecting. Similar to how onConnect can be used with esp_ble_gatts_cb_param_t now.

Tests scenarios

Tested on ESP32-S3-DevKitC-1, Platform-IO 5.1.1 (framework=Arduino), while connecting with 2 BLE devices (android and ios) simultaneous, reconnecting them one at a time.

Related links

Closes #6008

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Admin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@VojtechBartoska VojtechBartoska added Status: Awaiting triage Issue is waiting for triage Area: BT&Wifi BT & Wifi related issues labels Dec 14, 2022
@VojtechBartoska VojtechBartoska added this to the 2.0.6 milestone Dec 14, 2022
@me-no-dev
Copy link
Member

@RM-Alltrons could you please sign the CLA so we can merge your changes?

@RM-Alltrons
Copy link
Contributor Author

@RM-Alltrons could you please sign the CLA so we can merge your changes?
When I pushed, I tried signing a few times, but that did not seem to work.
I now tried a different browser, it says that "You have agreed to the CLA for espressif/arduino-esp32", but CLA-batch does not confirm that.

@me-no-dev
Copy link
Member

@RM-Alltrons I guess your local github settings cause you to commit as "Admin" which is not your username and that causes the problem. I will merge it anyway :) Thanks!

@me-no-dev me-no-dev merged commit 5d614f5 into espressif:master Dec 14, 2022
Human pushed a commit to Human/arduino-esp32 that referenced this pull request Dec 17, 2022
DamianSuess added a commit to DamianSuess/EspBleLibrary that referenced this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BT&Wifi BT & Wifi related issues Status: Awaiting triage Issue is waiting for triage
Projects
Development

Successfully merging this pull request may close these issues.

BLEServer.h callback onDisconnect() missing esp_ble_gatts_cb_param_t parameter
4 participants