Skip to content

fixes non existent esp32_adc2gpio #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2022
Merged

fixes non existent esp32_adc2gpio #7526

merged 5 commits into from
Dec 13, 2022

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Replaces non existant esp32_adc2gpio() with analogChannelToDigitalPin() in all the necessary "pins_arduino.h" files.

Tests scenarios

Just a compilation test with the ESP32/ESP32S2/ESP32S3/ESP32C3 variants.

Related links

Fixes #7516

@SuGlider SuGlider added the Type: Bug 🐛 All bugs label Nov 28, 2022
@SuGlider SuGlider added this to the 2.0.6 milestone Nov 28, 2022
@SuGlider SuGlider self-assigned this Nov 28, 2022
@SuGlider SuGlider mentioned this pull request Nov 28, 2022
Closed
1 task
@VojtechBartoska VojtechBartoska added the Area: Peripherals API Relates to peripheral's APIs. label Nov 28, 2022
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look on my comment, just small formatting issue that's triggering me a bit 😄
Else LGTM!

@me-no-dev me-no-dev merged commit 11c7d8e into espressif:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@PilnyTomas PilnyTomas Awaiting requested review from PilnyTomas

Assignees

@SuGlider SuGlider

Labels
Area: Peripherals API Relates to peripheral's APIs. Type: Bug 🐛 All bugs
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.

'esp32_adc2gpio' was not declared while compiling for um_tinys3
4 participants
@SuGlider @me-no-dev @P-R-O-C-H-Y @VojtechBartoska