-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Added support for heltec_wifi_lora_32_V3 and heltec_wifi_kit_32_V3 #7410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes to be committed: new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h
@Baptou88 The new boards are missing in our boards.txt file and has to be added if needed. So adding this is useless without that. If you want these boards in Arduino-esp32 feel free to add them to the boards.txt. After that I will review the changes. |
Changes to be committed: new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h modified: boards.txt
thanks @P-R-O-C-H-Y for your reply! I've modified board.txt, I hope it will be good |
@Baptou88 Overall looks good, but as the previous HELTEC boards already existing in our boards.txt can you please add the "heltec" at the start of the name? Will make more sense better :) |
@P-R-O-C-H-Y I just fixed boards.txt file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Baptou88 PTAL on my comments. After changes please try to compile with the boards to be sure its working 👍
boards.txt
Outdated
heltec_wifi_lora_V3.upload.tool.default=esptool_py | ||
heltec_wifi_lora_V3.upload.tool.network=esp_ota | ||
|
||
heltec_wifi_lora_V3.upload.maximum_size=1310720 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. When partition is fixed to default_8MB, I can't see that upload.maximus_size corresponds to the partition default_8MB.
esp32s3.menu.PartitionScheme.default_8MB.upload.maximum_size=3342336
static const uint8_t SCL_OLED = 18; | ||
static const uint8_t SDA_OLED = 17; | ||
|
||
#endif /* Pins_Arduino_h */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new line at the end of the file to keep standart formatting.
static const uint8_t RST_OLED = 21; | ||
static const uint8_t SCL_OLED = 18; | ||
static const uint8_t SDA_OLED = 17; | ||
#endif /* Pins_Arduino_h */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new line at the end of the file to keep standart formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line after #endif /* Pins_Arduino_h */. So there will be empty line number 83.
I'm testing the changes I made: here's what I did:
[env:heltec_wifi_kit_32_V3]
platform = C:\Users\Baptou88\Documents\GitHub\platform-espressif32
board = heltec_wifi_kit_32_V3
framework = arduino
platform_packages = framework-arduinoespressif32 @ C:/Users/Baptou88/Documents/GitHub/arduino-esp32
[env:heltec_wifi_lora_32_V3]
platform = C:\Users\Baptou88\Documents\GitHub\platform-espressif32
board = heltec_wifi_lora_32_V3
framework = arduino
platform_packages = framework-arduinoespressif32 @ symlink://C:/Users/Baptou88/Documents/GitHub/arduino-esp32
|
@Baptou88 Can you commit the changes so I can review again and do test? |
static const uint8_t RST_OLED = 21; | ||
static const uint8_t SCL_OLED = 18; | ||
static const uint8_t SDA_OLED = 17; | ||
#endif /* Pins_Arduino_h */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line after #endif /* Pins_Arduino_h */. So there will be empty line number 83.
@Baptou88 Any updates? |
I did not update this PR. I don't have the skills to do it right. I don't understand what modification I have to make for it to be valid |
thank you for helping me @P-R-O-C-H-Y ! |
No problem @Baptou88 :) feel free to open new PR with the modifications. |
There are only two changes since the merge - I will create a PR for the latter right now since it's easy. |
The I2C pin change is now #7709 I'll get to the wireless stick add in a day or two. |
Changes to be committed:
new file: variants/heltec_wifi_kit_32_v3/pins_arduino.h
new file: variants/heltec_wifi_lora_32_V3/pins_arduino.h
Source: https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series/tree/master/esp32/variants