Skip to content

Unify time modification on SD and SPIFFS #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2018
Merged

Unify time modification on SD and SPIFFS #738

merged 5 commits into from
Mar 4, 2018

Conversation

luc-github
Copy link
Contributor

need espressif/esp-idf#1128
to be applied to work

@@ -70,6 +70,7 @@ class File : public Stream
size_t size() const;
void close();
operator bool() const;
time_t getLastWrite();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space here? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho bad formating ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it - thank you

@me-no-dev
Copy link
Member

@luc-github this good to go?

@luc-github
Copy link
Contributor Author

luc-github commented Oct 25, 2017

Yes but need idf first no ?
Sample may be confusing if apply this PR only, no ?

@me-no-dev me-no-dev merged commit adf513f into espressif:master Mar 4, 2018
@luc-github
Copy link
Contributor Author

thank you ^_^

Curclamas pushed a commit to Curclamas/arduino-esp32 that referenced this pull request Aug 21, 2018
* Add access to last write date time

add example

* rename cpp to ino orz

* wrong copy -past

* No comment orz

* Add missing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants