-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix set/getSocketOption inheritance #7270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix set/getSocketOption inheritance #7270
Conversation
@bertmelis - Closed by mistake or is there a reason for it? |
By mistake. I deleted the forked repo but I forgot I had this PR open. |
OK, it is not possible to merge it or to rebase it. |
Oh. I'll recreate it exactly the same. I deleted the repo from GitHub when doing some spring cleaning. There's no way to restore. |
I recreated -not restored- the repo in the exact state as it was. I don't know if it is possible to merge in this state. IF not, I'll close this PR and create a new one. |
@SuGlider Let me know if it doesn't work. I'll make a new PR. |
@bertmelis seems okay, you just need to update the base branch. |
Well, apparently it doesn't work. I synced the branch but the update doesn't show up here. I deleted the repo by mistake and recreated it. But in this process the PR and the new fork aren't linked anymore. |
Closing in favour of #7480 |
Thanks for new PR @bertmelis! |
Description of Change
int WiFiClient::fd() const
tovirtual int WiFiClient::fd() const
int WiFiClientSecure::fd() const
setSocketOption
,getSocketOption
fromWiFiClientSecure
to deduplicate the code.setSocketOption
,getSocketOption
,getOption
, andsetOption
inWiFiClient
operate onfd()
. With this fix they all operate on the correct socket.setNoDelay
andgetNoDelay
now also works forWiFiClientSecure
.Tests scenarios
tested using WiFiclientSecure and WiFiClient on esp32devkit v1, connected and setNoDelay.
Tested using the MQTT client as referenced to in the issue #7244
Related links
Closes #7244