Add newly board (Deneyap Kart G) #7257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Deneyap Family member, wearable development board
me-no-dev
reviewed
Sep 15, 2022
| deneyapmini.menu.UploadMode.default.upload.use_1200bps_touch=true | ||
| deneyapmini.menu.UploadMode.default.upload.wait_for_upload_port=true | ||
| deneyapmini.menu.UploadMode.default.upload.mode=default_reset | ||
| deneyapmini.menu.UploadMode.cdc=UART0 |
There was a problem hiding this comment.
CDC is USB, not UART0. You can just switch the order of items to have USB as default
|
Please fill the PR description with some info about the boards you are adding. Links to manufacturer, etc. |
@me-no-dev I did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add newly board (Deneyap Kart G)
New Deneyap Family member, wearable development board
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v2.0.4, v2.0.3
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)