Skip to content

update Adafruit boards #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

update Adafruit boards #7025

merged 1 commit into from
Jul 27, 2022

Conversation

hathach
Copy link
Contributor

@hathach hathach commented Jul 22, 2022

Description of Change

  • Update Adafruit definitions in boards.txt, use correct partition scheme for 8MB variants
  • Update tinyuf2 for Adafruit from 0.9.2 to 0.10.2 version

Tests scenarios

  • Tested with all the boards from Adafruit (esp32, s2, s3, c3) with WiFIClient & I2C_scan sketch. Everything works well.

@ladyada

@VojtechBartoska VojtechBartoska requested a review from SuGlider July 25, 2022 14:16
@SuGlider SuGlider self-assigned this Jul 26, 2022
SuGlider
SuGlider reviewed Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider
Copy link
Collaborator

@hathach -
Please update this PR with the base branch in order to proceed with merging.
I can't rebase your GH branch as it seems to be blocked for me.

@hathach hathach force-pushed the update-adafruit-boards branch from 5b24931 to 603efe7 Compare July 27, 2022 05:02
@hathach
Copy link
Contributor Author

hathach commented Jul 27, 2022

@hathach - Please update this PR with the base branch in order to proceed with merging. I can't rebase your GH branch as it seems to be blocked for me.
Thanks for the review. Just done, I tried to find option to allow changes for upstream maintainer. But didn't quite figure where it is. Will try to do that in all of next PRs.

@VojtechBartoska VojtechBartoska added the Status: Pending Merge Pull Request is ready to be merged label Jul 27, 2022
@SuGlider SuGlider merged commit e10b528 into espressif:master Jul 27, 2022
@SuGlider
Copy link
Collaborator

thanks @hathach - Merged.

@hathach hathach deleted the update-adafruit-boards branch August 2, 2022 01:47
@VojtechBartoska VojtechBartoska removed the Status: Pending Merge Pull Request is ready to be merged label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider left review comments

Assignees

@SuGlider SuGlider

Labels
Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hathach @SuGlider @VojtechBartoska