UpdateClass - speedup flash erase/writes #7002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- on flash writes try to use large block erase - skip writing empty blocks of data after erase
|
Very nice optimization @vortigont, I really liked it! Thanks! |
|
We use your PR in latest Tasmota Arduino esp32 framework. It does work well and we have got not a single issue regarding OTA since this change. |
|
Thanks @Jason2866. Having a positive tests feedback from a projects like Tasmota is much appreciated. |
VojtechBartoska
added
the
Status: Pending Merge
P-R-O-C-H-Y
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Thanks @vortigont for the PR 👍 ! Really nice speed improvement. Tested on ESP32+ESP32S3 with smaller sketch, but got upload time 30-40% faster 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seriously speeds up OTA image flashing process.
I was working on a esp32-flashz lib implementing compressed OTA updates and found that UpdateClass is really slow on image writes. Even slower than esptool over serial. Looks like the main issue is in slow per-sector erase cycles.
This change implements the following:
It gives 2-3 times speedup for raw image writes. Suppose it also depends on flash chip used.
Tested with FW/FS images