Add ESP-C3-M1-I-Kit board #6938

wmjohnanderson · 2022-07-04T13:54:53Z

Summary
PR for ESP-C3-M1-I-Kit board in variants

I am current summer intern learning as much as I can and using this as practice. This is my first time doing this so if there is anything wrong, or any issues let me know and I can work on it. Thanks!

CLAassistant · 2022-07-04T14:31:21Z

All committers have signed the CLA.

ajsb85 · 2022-07-04T17:20:28Z

Dear @me-no-dev
For your references:
platformio/platform-espressif32#841

https://docs.ai-thinker.com/en/esp32c3
https://docs.ai-thinker.com/_media/esp32/docs/esp-c3-m1-i_v1.1.1_specification.pdf
https://docs.ai-thinker.com/_media/esp32/docs/nodemcu-esp-c3-m1-i-kit_v1.2.0_specification.pdf

Best regards.

ajsb85 · 2022-07-04T17:28:24Z

Hi, @wmjohnanderson
Thank you for the contribution.
Could you please rename the folder to create a proper slug name.
Example: from ESP-C3-M1-I-Kit is esp_c3_m1_i_kit
Thank you in advance.

atanisoft · 2022-07-05T12:19:02Z

This creates a pins variant but doesn't define any board to use it. Please update boards.txt to have a reference to this new board.

atanisoft · 2022-07-05T12:22:51Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t SS    = 23;
+static const uint8_t MOSI  = 21;
+static const uint8_t MISO  = 22;
+static const uint8_t SCK   = 28;


the above four pins are not recommended for use or do not exist on the ESP32-C3. These should be remapped to valid pins.

@wmjohnanderson - suggestion:

static const uint8_t SS = 5; static const uint8_t MOSI = 10; static const uint8_t MISO = 6; static const uint8_t SCK = 7;

atanisoft · 2022-07-05T12:24:44Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t A2 = 4;
+static const uint8_t A3 = 5;
+static const uint8_t A4 = 6;
+static const uint8_t A5 = 13;


GPIO 0 - 5 are the only ADC pins, GPIO 13 does not exist.

@wmjohnanderson - suggestion:

static const uint8_t A0 = 0; static const uint8_t A1 = 1; static const uint8_t A2 = 2; static const uint8_t A3 = 3; static const uint8_t A4 = 4; static const uint8_t A5 = 5;

atanisoft · 2022-07-05T12:25:23Z

esp_c3_m1_i_kit/pins_arduino.h

+#define digitalPinHasPWM(p)         (p < EXTERNAL_NUM_INTERRUPTS)
+
+static const uint8_t LED_BUILTIN = 18;
+static const uint8_t LED_BUILTIN = 19;


Duplicate pin define... which is it?

@wmjohnanderson - suggestion:

static const uint8_t LED_C = 18; static const uint8_t LED_W = 19; static const uint8_t LED_BUILTIN = 19; #define BUILTIN_LED LED_BUILTIN // backward compatibility

SuGlider · 2022-07-12T19:07:38Z

@wmjohnanderson @ajsb85

Please verify the suggestions and review from @atanisoft in order to move forward.
Thanks!

VojtechBartoska · 2022-07-27T12:06:47Z

@wmjohnanderson Any updates so we can move forward with this PR?

VojtechBartoska · 2022-09-05T12:44:31Z

@wmjohnanderson Can you help process suggested changes?

SuGlider · 2022-09-06T01:39:19Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t LED_BLUE = 5;
+
+static const uint8_t TX = 18;
+static const uint8_t RX = 19;


This is the correct pins used in this boards. GPIO18 and 19 are LEDs and USB JTAG/CDC.

static const uint8_t TX = 21; static const uint8_t RX = 20;

SuGlider · 2022-09-06T01:40:00Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t RX = 19;
+
+static const uint8_t SDA = 4;
+static const uint8_t SCL = 5;


My suggestion based on the boards layout would be:

static const uint8_t SDA = 1; static const uint8_t SCL = 2;

Fixed with standard ESP32-C3 definition.

SuGlider · 2022-09-06T01:41:22Z

This creates a pins variant but doesn't define any board to use it. Please update boards.txt to have a reference to this new board.

@wmjohnanderson - As @atanisoft already said, we also need that you make proper changes to boards.txt in order to add this boards to the list.

SuGlider

@wmjohnanderson - Please check all the pending requested changes.

P-R-O-C-H-Y · 2022-12-02T14:21:27Z

@wmjohnanderson Hi, is this PR still valid as there is no reaction from you for a long time.

SuGlider

Fixed all pending issue in order to move forward and get it merged.

SuGlider · 2022-12-07T19:02:37Z

esp_c3_m1_i_kit/pins_arduino.h

+#define digitalPinHasPWM(p)         (p < EXTERNAL_NUM_INTERRUPTS)
+
+static const uint8_t LED_BUILTIN = 18;
+static const uint8_t LED_BUILTIN = 19;


SuGlider · 2022-12-07T19:02:46Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t LED_BLUE = 5;
+
+static const uint8_t TX = 18;
+static const uint8_t RX = 19;


SuGlider · 2022-12-07T19:03:07Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t RX = 19;
+
+static const uint8_t SDA = 4;
+static const uint8_t SCL = 5;


Fixed with standard ESP32-C3 definition.

SuGlider · 2022-12-07T19:03:19Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t SS    = 23;
+static const uint8_t MOSI  = 21;
+static const uint8_t MISO  = 22;
+static const uint8_t SCK   = 28;


SuGlider · 2022-12-07T19:03:28Z

esp_c3_m1_i_kit/pins_arduino.h

+static const uint8_t A2 = 4;
+static const uint8_t A3 = 5;
+static const uint8_t A4 = 6;
+static const uint8_t A5 = 13;


SuGlider · 2022-12-07T19:05:51Z

@wmjohnanderson Any updates so we can move forward with this PR?

@VojtechBartoska @P-R-O-C-H-Y - I have searched this board specification and fixed all the pinout definition.
Please review it. ~~I think we can go ahead and get it merge it~~

It still misses modifications to board.txt file.

SuGlider · 2022-12-07T21:29:03Z

@P-R-O-C-H-Y - Please double check it and if it is ready, please merge it. Thanks!

Fixes board.txt file to add the new ESP32_C3_M1_I_KIT variant

SuGlider · 2022-12-08T19:08:14Z

This creates a pins variant but doesn't define any board to use it. Please update boards.txt to have a reference to this new board.

This is done now.

me-no-dev · 2022-12-13T10:03:06Z

Specs say that the module comes with 4MB Flash, so I suggest (strongly) that the unnecessary options are removed (flash size, flash mode, flash freq and partitions that would not fit) 4MB 80Mhz QIO should be default and only option

me-no-dev · 2022-12-13T10:03:47Z

Also this module does not differ in any functional way from the default ESP32-C3 Dev Module

me-no-dev · 2022-12-13T10:06:28Z

@ajsb85 @wmjohnanderson have you tested USB connected to IOs 18 and 19? Does it work OK with the LEDs that you have added?

SuGlider · 2022-12-13T23:14:44Z

@ajsb85 @wmjohnanderson have you tested USB connected to IOs 18 and 19? Does it work OK with the LEDs that you have added?

The board has a CH340. I think it doesn't mind about USB pins.
Maybe it can just disable menu option for CDC.

me-no-dev · 2022-12-14T10:46:11Z

@SuGlider you still have the options for Flash Frequency and Flash Mode, which I find redundant as well. 4MB 80Mhz QIO is all that is needed

SuGlider · 2022-12-14T14:41:35Z

@SuGlider you still have the options for Flash Frequency and Flash Mode, which I find redundant as well. 4MB 80Mhz QIO is all that is needed

I think it is fine now. Let me know.

ajsb85 · 2022-12-15T11:29:27Z

Hi, @me-no-dev

I will take a look all the features and review the PR in deep with that board.

Thank you very much for the merged into the repo.

* feat: add ESP-C3-M1-I-Kit board to variants * docs: rename file to slug format * Fixes GPIO definitions * Adds ESP32 C3 M1 I Kit to the board list Fixes board.txt file to add the new ESP32_C3_M1_I_KIT variant * fixes extra board separator * Keeps only 4MB flash option * Fix it to Flash 80Mhz QIO only * Undo a change by mistake Co-authored-by: Rodrigo Garcia <[email protected]>

feat: add ESP-C3-M1-I-Kit board to variants

8e0f9d6

ajsb85 mentioned this pull request Jul 4, 2022

Add ESP-C3-M1-I-Kit to boards platformio/platform-espressif32#841

Merged

docs: rename file to slug format

a402615

atanisoft reviewed Jul 5, 2022

View reviewed changes

VojtechBartoska added the Type: 3rd party Boards label Jul 14, 2022

SuGlider self-assigned this Aug 8, 2022

SuGlider added Status: Pending Resolution: Awaiting response Waiting for response of author labels Aug 8, 2022

SuGlider reviewed Sep 6, 2022

View reviewed changes

SuGlider self-requested a review September 6, 2022 01:42

SuGlider requested changes Sep 6, 2022

View reviewed changes

SuGlider added 2 commits December 7, 2022 15:20

Merge branch 'master' into master

e512bdd

Fixes GPIO definitions

4c6d23a

SuGlider approved these changes Dec 7, 2022

View reviewed changes

SuGlider added this to the 2.0.6 milestone Dec 7, 2022

Merge branch 'master' into master

f8fdb5e

SuGlider requested a review from P-R-O-C-H-Y December 7, 2022 21:28

P-R-O-C-H-Y self-assigned this Dec 8, 2022

SuGlider added 4 commits December 8, 2022 09:14

Merge branch 'master' into master

d9c508e

Merge branch 'master' into master

8ee7285

Adds ESP32 C3 M1 I Kit to the board list

ddaa4f5

Fixes board.txt file to add the new ESP32_C3_M1_I_KIT variant

fixes extra board separator

15155af

ajsb85 approved these changes Dec 9, 2022

View reviewed changes

Merge branch 'master' into master

461702b

SuGlider added 2 commits December 13, 2022 20:00

Merge branch 'master' into master

f22b49b

Keeps only 4MB flash option

13a3def

SuGlider added 2 commits December 14, 2022 09:33

Merge branch 'master' into master

8b5302e

Fix it to Flash 80Mhz QIO only

62ed322

SuGlider added 2 commits December 14, 2022 11:43

Undo a change by mistake

fb00d6e

Merge branch 'master' into master

ebd27cd

me-no-dev merged commit 972c3bb into espressif:master Dec 14, 2022

Add ESP-C3-M1-I-Kit board #6938

Add ESP-C3-M1-I-Kit board #6938

Conversation

wmjohnanderson commented Jul 4, 2022

CLAassistant commented Jul 4, 2022 • edited Loading

ajsb85 commented Jul 4, 2022

ajsb85 commented Jul 4, 2022

atanisoft commented Jul 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuGlider commented Jul 12, 2022

VojtechBartoska commented Jul 27, 2022

VojtechBartoska commented Sep 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuGlider commented Sep 6, 2022

SuGlider left a comment

Choose a reason for hiding this comment

P-R-O-C-H-Y commented Dec 2, 2022

SuGlider left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuGlider commented Dec 7, 2022 • edited Loading

SuGlider commented Dec 7, 2022

SuGlider commented Dec 8, 2022

me-no-dev commented Dec 13, 2022

me-no-dev commented Dec 13, 2022

me-no-dev commented Dec 13, 2022

SuGlider commented Dec 13, 2022 • edited Loading

me-no-dev commented Dec 14, 2022

SuGlider commented Dec 14, 2022

ajsb85 commented Dec 15, 2022

CLAassistant commented Jul 4, 2022 •

edited

Loading

SuGlider commented Dec 7, 2022 •

edited

Loading

SuGlider commented Dec 13, 2022 •

edited

Loading